Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3420 closed change (fixed)

Get rid of for each loops in Diagnostics

Reported by: trev Assignee: trev
Priority: P3 Milestone: Diagnostics-1.3.1-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By: #3463
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332787/

Description (last modified by trev)

Background

for each loops are deprecated and will produce a warning in Firefox 45. Yet our Diagnostics extension is still using them.

What to change

Replace for each loop by for of loops.

What to test

Extension's main window should still work (display results and color them correctly).

Change History (3)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by trev

  • Blocked By 3463 added
Note: See TracTickets for help on using tickets.