Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3421 closed change (fixed)

Get rid of for each loops in keySelector.js

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #312, #1434 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332790/

Description

Background

for each loops are deprecated and will produce a warning in Firefox 45. Yet keySelector.js is still using them.

What to change

Replace for each loop by for of loops.

Change History (4)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by trev

  • Blocking 312 added

comment:4 Changed 4 years ago by sebastian

  • Blocking 1434 added
Note: See TracTickets for help on using tickets.