Opened 4 years ago

Closed 4 years ago

#3427 closed defect (fixed)

First Run actions are not performed

Reported by: Ross Assignee: trev
Priority: P1 Milestone: Adblock-Plus-1.10-for-Chrome-Opera-Safari
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332839/

Description (last modified by trev)

Environment

ABP 1.9.4.1503
Chrome 47.0.2526.80 / Ubuntu 14.04 x64

How to reproduce

  1. Uninstall ABP / Reset to clean state.
  2. Install latest ABP dev build from store link.
  3. Observe extension is installed and Chrome points it out.
  4. Observe the FRP is not opened.
  5. Select [ABP] > [Options].
  6. Observe no default filter lists are installed.
  7. Observe Acceptable Ads checkbox is not by default checked.

...

Observed behaviour

The "First Run" actions such as showing a First Run Page, adding default filter lists and setting the AA checkbox are not performed.

Expected behaviour

The "First Run" actions to complete successfully.

Background

ext.EventTarget doesn't correctly handle the case where a listener will remove itself when called - the next listener will be skipped in loop then.

Change History (7)

comment:1 Changed 4 years ago by Ross

This also occurs as described in Opera.

ABP 1.9.4.1503
Opera 34.0.2036.25 / Ubuntu 14.04 x64

comment:2 Changed 4 years ago by philll

  • Component changed from Extensions-for-Adblock-Plus to Unknown
  • Milestone Adblock-Plus-1.9.5-for-Chrome-Opera-Safari deleted
  • Priority changed from P2 to P1

comment:3 Changed 4 years ago by philll

  • Ready set

comment:4 Changed 4 years ago by philll

This behaviour started with Adblock Plus for Google Chrome 1.9.4.1501

comment:5 Changed 4 years ago by trev

  • Description modified (diff)
  • Owner set to trev

comment:6 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-1.9.5-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.