Opened 4 years ago

Last modified 4 years ago

#3428 new change

Decide the UI details for non-blockable URL's

Reported by: eric@… Assignee:
Priority: Unknown Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: oleksandr, sergz Blocked By: #1596, #1720
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

ABP for IE only intercepts "http:" and "https:" protocols. It can't block other resources, such as "file:" and "about:", so we shouldn't offer any option to do so. (See #1596, #1720) The question is how not to offer this option and how to communicate it clearly to users.

What to change

There's a pop-up menu option to "block only on this site", the one that shouldn't be offered. The question is how not to offer this option.

The first choice to make is whether to disable (grey-out) the option or to remove it from the menu entirely. If it's removed, there aren't any further choices. If it's left it, there are a couple of small issues left. First, should the text in the option remain the same, or change to reflect its disabled status? If it stays the same, should there be a tool-tip to explain it? Should the option be checked or unchecked?

Change History (4)

comment:1 Changed 4 years ago by eric@…

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Platform changed from Unknown / Cross platform to Internet Explorer

comment:2 Changed 4 years ago by sergz

  • Cc oleksandr sergz added

Removing of the item seems to be consistent with UX in Chrome and Firefox.

comment:3 Changed 4 years ago by sergz

Can be related issue #2070

comment:4 Changed 4 years ago by eric@…

The specific issue raised #2070 has been partially obsoleted by the new popover (a.k.a. bubble) UI in Firefox. Here's one of the UI illustrations from that ticket:
https://issues.adblockplus.org/attachment/ticket/2070/firefox_bubbleUI_v11.png

If consistency is the goal, then we should listen to @sven, our designer. From that ticket:

The right way would be to implement the features from firefox also for chrome instead of trying to unify something which is not completed in other platforms.

The (new) Firefox way is to have three items in a submenu. See the illustration in the above link. The chrome behavior is to remove the menu item. It is a false kind of consistency to make the behavior of IE on this matter consistent with Chrome, since that's the wrong target.

If we make changes here short of implementing the entire popover menu, we should at least make changes that move toward it. The new UI does not remove menu items, but rather leaves them in and shows them as disabled.

It also changes the item text when it does that, which seems like a much better change to make first. We'll need the translation string eventually, as well.

Note: See TracTickets for help on using tickets.