Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#343 closed defect (fixed)

[Chrome 35*] element hiding breaks with error in event handler

Reported by: philll Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6289175791796224/
http://codereview.adblockplus.org/5197857351008256/

Description

Environment

Chrome Version 35.0.1916.27 beta-m
ABP 1.7.4.1155
Easylist & Easylist Germany

How to reproduce

  1. Go to http://www.spiegel.de/

Observed behaviour

Ad images are blocked but unloaded content icons stay displayed. The console output is as follows:

Error in event handler for (unknown): Failed to execute 'insertRule' on 'CSSStyleSheet': Failed to parse the rule '::-webkit-distributed(#Ad_Win2day), ::-webkit-distributed(#SSpotIMPopSlider), ::-webkit-distributed(#SlimSpot_imPop_Container), ::-webkit-distributed(#Werb_Postbit_Bottom), ::-webkit-distributed(#WerbungObenRechts10_GesamtDIV), ::-webkit-distributed(#WerbungObenRechts8_GesamtDIV), ::-webkit-distributed(#WerbungObenRechts9_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks4_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks7_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks8_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks9_GesamtDIV), ::-webkit-distributed(#Werbung_Sky), ::-webkit-distributed(#Werbung_Wide), ::-webkit-distributed(#__ligatus_placeholder__), ::-webkit-distributed(#ad-bereich1-08), ::-webkit-distributed(#ad-bereich1-superbanner), ::-webkit-distributed(#ad-bereich2-08), ::-webkit-distributed(#ad-bereich2-skyscrapper), ::-webkit-distributed(#ad-rechts-block), ::-webkit-distributed(#ad-rechts-sky) { display: none !important; }'.
Stack trace: Error: Failed to execute 'insertRule' on 'CSSStyleSheet': Failed to parse the rule '::-webkit-distributed(#Ad_Win2day), ::-webkit-distributed(#SSpotIMPopSlider), ::-webkit-distributed(#SlimSpot_imPop_Container), ::-webkit-distributed(#Werb_Postbit_Bottom), ::-webkit-distributed(#WerbungObenRechts10_GesamtDIV), ::-webkit-distributed(#WerbungObenRechts8_GesamtDIV), ::-webkit-distributed(#WerbungObenRechts9_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks4_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks7_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks8_GesamtDIV), ::-webkit-distributed(#WerbungUntenLinks9_GesamtDIV), ::-webkit-distributed(#Werbung_Sky), ::-webkit-distributed(#Werbung_Wide), ::-webkit-distributed(#__ligatus_placeholder__), ::-webkit-distributed(#ad-bereich1-08), ::-webkit-distributed(#ad-bereich1-superbanner), ::-webkit-distributed(#ad-bereich2-08), ::-webkit-distributed(#ad-bereich2-skyscrapper), ::-webkit-distributed(#ad-rechts-block), ::-webkit-distributed(#ad-rechts-sky) { display: none !important; }'.
    at Error (native)
    at setElemhideCSSRules (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/include.preload.js:53:17)
    at messageListener (extensions::messaging:340:9)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at EventImpl.dispatchToListener (extensions::event_bindings:395:22)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Event.publicClass.(anonymous function) [as dispatchToListener] (extensions::utils:65:26)
    at EventImpl.dispatch_ (extensions::event_bindings:378:35)
    at EventImpl.dispatch (extensions::event_bindings:401:17)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14) (index):1
Failed to load resource: net::ERR_BLOCKED_BY_CLIENT http://adserv.quality-channel.de/RealMedia/ads/adstream_mjx.ads/www.spiegel…VRight,x01,x02,x03,x04,x05,x06,x07,x08,x09,x10,x11,x12,x20,x21,x22,x23,x70
Failed to load resource: net::ERR_BLOCKED_BY_CLIENT http://adserv.quality-channel.de/RealMedia/ads/adstream_nx.ads/www.spiegel.…t,x01,x02,x03,x04,x05,x06,x07,x08,x09,x10,x11,x12,x20,x21,x22,x23,x70!Top1
[...]

Expected behaviour

As in Chrome 34 with the same ABP version, the elements containing the ads should be hidden without errors in console

Change History (8)

comment:1 Changed 5 years ago by sebastian

  • Owner set to sebastian
  • Status changed from new to assigned

comment:2 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from assigned to reviewing

comment:3 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 5 years ago by philll

  • Resolution fixed deleted
  • Status changed from closed to reopened

The event handler error is gone now, but elements are still not hidden at the same website with the same filter but ABP 1.7.4.1157. Chrome is now at Version 35.0.1916.47 beta-m

comment:6 Changed 5 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

The initial patch works as expected, fixing element hiding filters. However apparently element collapsing (hiding of elements blocked by request blocking filters) is broken as well in Chrome 35.

Last edited 5 years ago by sebastian (previous) (diff)

comment:7 Changed 5 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 5 years ago by trev

  • Component changed from Unknown to Platform
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Ready set
Note: See TracTickets for help on using tickets.