Opened 4 years ago

Closed 4 years ago

#3430 closed change (fixed)

Get rid of expression closure in EHH's common.js

Reported by: trev Assignee: trev
Priority: P3 Milestone: Element-Hiding-Helper-1.3.6
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332858/

Description

Background

Expression closures are deprecated and cause a warning in Firefox 45. Yet it seems that we still have one instance in Element Hiding Helper's common.js.

What to change

Replace the expression closure by a regular function.

Change History (2)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Platform changed from Unknown / Cross platform to Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.