Opened 4 years ago

Closed 4 years ago

#3443 closed change (fixed)

Use process script instead of a frame script in Element Hiding Helper

Reported by: trev Assignee: trev
Priority: P2 Milestone: Element-Hiding-Helper-1.3.6
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332902/

Description

Background

Element Hiding Helper currently uses frame scripts in the content process. This causes issues because frame scripts are loaded for each individual tab - so the frame scripts have to load a JavaScript module. It's a waste of memory and causes significant overhead when Element Hiding Helper is disabled (each frame script is performing shutdown actions). Finally, properly unloading the JavaScript module doesn't work because the corresponding chrome package is already unloaded at that point.

What to change

Use process scripts which will automatically create a single instance per process.

Change History (2)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.