Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#3444 closed change (fixed)

Remove migration code, resetting Prefs.hidePlaceholders

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.10.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29332923

Description (last modified by sebastian)

Background

In Adblock Plus 1.8.9, we removed the "Hide placeholders of blocked elements" option (#1671). As this feature is still available, but merely hidden from the options page, it gets automatically reset when updating from a version that still had it exposed on the options page.

This migration code soon has been in the extension for a year and 10 releases. So almost all users migrated already and that code can be removed now.

What to change

Remove the migration code, that resets Prefs.hidePlaceholders, when updating from <1.8.8.1285.

Hints for testers

  • Make sure that Prefs.hidePlaceholders is set to true by default, that means for example that when an image is blocked with a blocking (not element hiding) filter, that no placeholder show up.
  • Make sure that extension initialization works, i.e. that default filter lists are configured and that the first run page shows up on installation; that settings are preserved when updating the extension or restarting the browser.

Change History (9)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 3 years ago by sebastian

  • Description modified (diff)

comment:5 Changed 3 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:7 Changed 2 years ago by kzar

  • Cc kzar added

comment:8 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:9 Changed 2 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set

Done.

  • Prefs.hidePlaceholders is set to true
  • Extensions initialisation works
  • The default filter lists are configured and the first run page shows upon instaltion
  • Settings are preserved upon upgrading the extension

Chrome 34, 46, 48
Safari 6, 7, 8
Opera 27, 30
Adblock Plus 1.10.0.1539

Note: See TracTickets for help on using tickets.