Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#3446 closed change (fixed)

Remove code migrating prefs and files to chrome.storage

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.10.1-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29332926

Description (last modified by sebastian)

Background

In Adblock Plus 1.9, we migrated from localStorage and the FileSystem API to chrome.storage (#2040, #2021). The respective migration code soon has been in the extension for 8 months and 6 releases. So almost all users migrated already and that code can be removed now.

What to change

Remove the code that migrates prefs and files to chrome.storage, as well as the respective migration code for Safari which unifies the data structure.

Hints for testers

Make sure that extension initialization works, i.e. that default filter lists are configured and that the first run page shows up on installation; that settings are preserved when updating the extension (from ABP 1.9 or any newer version) or restarting the browser.

Change History (5)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 2 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 2 years ago by kzar

  • Cc kzar added

comment:5 Changed 2 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set

Done.

  • The extension re-initialises after restart
  • The settings are preserved when updating the extension
  • The extension loads the default lists
  • The first run page shows up on first installation


Safari 6, 7, 8
Chrome 36, 37, 44, 45, 46, 48
Opera 28, 29, 30

Last edited 2 years ago by scheer (previous) (diff)
Note: See TracTickets for help on using tickets.