Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3448 closed defect (fixed)

"TypeError: this.treeElement is null" error when closing Filter Preferences

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29332935/

Description (last modified by trev)

Environment

Adblock Plus 2.7.0.4095-beta
Firefox 43

How to reproduce

  1. Click ABP icon and choose Filter preferences.
  2. Wait a bit and close the window again.

Observed behaviour

"TypeError: this.treeElement is null" exception shows up in Browser Console, thrown by filters-filterview.js line 668. There are no side-effects it seems.

Expected behaviour

No error messages.

Background

It seems that Firefox calls nsITreeView.setTree() with null parameter when the window is closed, this behavior must be new.

Change History (4)

comment:1 Changed 4 years ago by trev

  • Description modified (diff)

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

No treeview related errors appear when closing the console.

ABP 2.7.0.4128-beta
Firefox 43 / 44 / 45 Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.