Opened 4 years ago

Closed 4 years ago

#3451 closed defect (fixed)

Previously disabled filter is re-added as disabled when whitelisting a site

Reported by: mapx Assignee: greiner
Priority: P4 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, greiner Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333144/

Description

Environment

windows xp
FF 440b1
easylist
ABP 2.7.0.4098

How to reproduce

  • go to google.com
  • click ABP icon, click "disable on google.com"
  • refresh page
  • go to custom filters
  • uncheck (disable) the filter
    @@||google.com^$document
    
  • refresh
  • delete filter from custom filters
  • click again "disable on google.com"

Observed behaviour

the filter will be created but disabled. The site / page is not whitelisted.

Expected behaviour

the page / site should be whitelisted

Change History (6)

comment:1 Changed 4 years ago by greiner

I can confirm this issue.

Note that setting filter.disabled = false before adding it to the filter storage in UI.toggleFilter() fixes it.

comment:2 Changed 4 years ago by trev

  • Priority changed from Unknown to P4
  • Ready set

comment:3 Changed 4 years ago by trev

  • Summary changed from whitelisting site - tricky behaviour to Previously disabled filter is re-added as disabled when whitelisting a site

comment:4 Changed 4 years ago by greiner

  • Owner set to greiner

comment:5 Changed 4 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 4 years ago by greiner

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.