Opened 4 years ago

Closed 4 years ago

#3454 closed change (fixed)

Don't mark font requests as indistinguishable on Safari

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.10-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333040

Description

Background

Currently, we map the request type FONT to OTHER on Safari. That means that filters using the $font option will also match requests of type OTHER, and vice-versa. However, requests loading web fonts are actually not visible to the beforeload DOM event, as the they don't have a DOM element but are loaded with a CSS rule. Therfore these requests are not visible to Adblock Plus on Safari and effected filters should rather be ignored than applied to OTHER requests.

What to change

Don't mark FONT requests as indistinguishable on Safari.

Change History (2)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-1.10-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.