Opened on 12/27/2015 at 06:17:27 PM

Closed on 01/05/2016 at 09:37:08 AM

Last modified on 05/16/2019 at 07:57:53 AM

#3458 closed defect (fixed)

e10s changes broke popup blocking

Reported by: SMed79 Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, greiner, sebastian, mapx, arthur, erikvold Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mapx)


OS: Manjaro Linux, Debian Linux, Windows 10
Firefox 38,42,43, 44.0b4
ABP 2.7

How to reproduce

  1. Go to
  2. Click anywhere.

Observed behaviour

Open popup to and not closed despite the presence of filter | | $ popup, third-party on EasyList.

Expected behaviour

No popup if we block ||$script

same issue:

  1. go to
  2. click, speedvideo, Netu.TV ... or the X icone.

POPUP to not recognized.

Attachments (0)

Change History (15)

comment:1 Changed on 12/27/2015 at 08:13:53 PM by mapx

  • Cc trev greiner sebastian mapx added

comment:2 Changed on 12/27/2015 at 09:25:47 PM by sebastian

Reproduced with Firefox 38.0 and Adblock Plus
Not reproducible on Chrome 46.0.2490.71 with Adblock Plus

comment:3 Changed on 12/28/2015 at 02:52:47 PM by arthur

  • Cc arthur added

Fyi: works as expected with ABP 2.6.11 on FF 43.0.2.

comment:4 Changed on 12/29/2015 at 04:33:15 PM by sebastian

It's also already broken in Adblock Plus I'm testing on Firefox 42 now (latest version in Debian). However, for some reasons I cannot install builds of some older versions (anymore). Firefox is preventing these versions from installation with a rather bogus error message. This makes tracking down this bug not any easier. :(

Last edited on 12/29/2015 at 04:36:43 PM by sebastian

comment:5 Changed on 12/29/2015 at 04:38:39 PM by mapx

Did you already turned OFF (false)

comment:6 Changed on 12/29/2015 at 05:37:53 PM by sebastian

  • Cc erikvold added
  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Platform changed from Unknown / Cross platform to Firefox
  • Priority changed from Unknown to P1
  • Ready set
  • Summary changed from POPUP not recognized to e10s changes broke popup blocking

Yes, xpinstall.signatures.required has been disabled. It's weird and seem to happen rather randomly. However, wiping the Firefox profile seems to help when it does.

So I was able to track down the bug to be a regression introduced by 32d16e3d1cb8. But I'm not too familar with the Gecko APIs used there. Since Wladimir is on vacation, I loop in Erik.

comment:7 Changed on 12/29/2015 at 05:41:54 PM by sebastian

  • Summary changed from e10s changes broke popup blocking to e10s changes broke popup blocking (on Linux?)

comment:8 Changed on 12/29/2015 at 05:54:22 PM by mapx

Linux ? I can reproduce the issue in windows 10

comment:9 Changed on 12/29/2015 at 06:03:26 PM by sebastian

  • Description modified (diff)
  • Summary changed from e10s changes broke popup blocking (on Linux?) to e10s changes broke popup blocking

Well, before nobody confirmed that it's reproducible on other operating systems than Linux. But thanks for confirming that it in fact is also on Windows. I updated the issue.

comment:10 Changed on 12/29/2015 at 06:08:19 PM by mapx

  • Description modified (diff)

comment:11 Changed on 01/04/2016 at 02:34:26 PM by trev

This is reproducible reliably for me. Diagnostics shows that we only get about:blank as URL for this pop-up, never the final URL.

comment:12 Changed on 01/04/2016 at 02:40:42 PM by trev

  • Owner set to trev

comment:13 Changed on 01/04/2016 at 04:43:47 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:14 Changed on 01/05/2016 at 09:37:08 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:15 Changed on 01/18/2016 at 10:33:11 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Popup blocking is working.

Firefox 38 / 43 / 44 / 45 / 46.0a1 / Ubuntu 14.04 x64

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.