Opened on 12/28/2015 at 04:27:13 PM

Closed on 12/28/2015 at 05:19:47 PM

Last modified on 01/18/2016 at 10:41:58 AM

#3459 closed defect (fixed)

<img srcset>, <picture> and fetch() are recognized as other

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Images loaded from an URL provided by the srcet attribute or using the <picture> element are reported as TYPE_IMAGESET by Firefox, which is mapped to OTHER by Adblock Plus. Therefore filters using the $image option won't match these requests.

Also, requests send with the fetch() API are reported as TYPE_FETCH by Firefox, and mapped to OTHER as well by Adblock Plus. However, the fetch() API does essentially the same as the old XMLHttpRequest API. Therefore these requests should be rather mapped to XMLHTTPREQUEST, in order to match filters using the $xmlhttprequest option.

What to change

Map the content type IMAGESET to IMAGE and FETCH to XMLHTTPREQUEST.

Attachments (0)

Change History (11)

comment:1 Changed on 12/28/2015 at 04:28:33 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 12/28/2015 at 05:19:47 PM by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Priority changed from Unknown to P3
  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed on 12/29/2015 at 03:39:16 PM by sebastian

  • Review URL(s) modified (diff)

Added another patch adding tests.

comment:4 Changed on 12/29/2015 at 06:33:21 PM by sebastian

comment:5 Changed on 12/30/2015 at 03:41:57 PM by sebastian

  • Review URL(s) modified (diff)

comment:6 Changed on 01/01/2016 at 02:48:53 PM by sebastian

comment:7 Changed on 01/06/2016 at 01:30:22 PM by sebastian

  • Review URL(s) modified (diff)

comment:8 Changed on 01/06/2016 at 03:46:12 PM by sebastian

comment:9 Changed on 01/06/2016 at 04:43:05 PM by sebastian

  • Review URL(s) modified (diff)

comment:10 Changed on 01/07/2016 at 10:21:55 AM by sebastian

comment:11 Changed on 01/18/2016 at 10:41:58 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Images from srcset, picture and fetch() requests are detected as correct types.

Useful link:

Firefox 38 / 43 / 44 / 45 / 46.0a1 / Ubuntu 14.04 x64

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.