Opened 4 years ago

Closed 4 years ago

#3463 closed defect (fixed)

Filtering broken in Diagnostics

Reported by: trev Assignee: trev
Priority: P1 Milestone: Diagnostics-1.3.1-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: #3420 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333128/

Description

Environment

Diagnostics 1.3.0.254 in Firefox 46.0a1 nightly.

How to reproduce

  1. Open Diagnostics window.
  2. Enter something into the Filter field and press Enter.

Observed behaviour

List isn't filtered, instead "TypeError: entry.cols is not iterable watcher.js:413:16" appears in the Error Console.

Expected behaviour

List is filtered.

Change History (3)

comment:1 Changed 4 years ago by trev

  • Blocking 3420 added

This appears to be a regression from #3420.

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.