Opened 3 years ago

Closed 3 years ago

#3464 closed defect (fixed)

"subscriptionUpdateDataSource is undefined" error in Issue Reporter

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333147/

Description

Environment

Firefox 44 and higher, Adblock Plus 2.7.

How to reproduce

  1. Make sure your filter subscriptions aren't up-to-date (restore backup if necessary).
  2. Go to http://www.diynetwork.com/photos/top-pins-from-2015-pictures
  3. Click ABP icon and choose "Report issue on this page."
  4. Choose "Adblock Plus is blocking too much" and click Continue.

Observed behaviour

The message "Adblock Plus needs to update your filter subscriptions" appears but it never goes away unless you click Continue yourself. The message "ReferenceError: subscriptionUpdateDataSource is not defined" appears in the Error Console. Filter subscriptions stay outdated.

Expected behaviour

Filter subscriptions are updated and the wizard continues automatically, no errors thrown.

Background

This is yet again fallout from bug 1202902.

Change History (2)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.