Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3465 closed change (fixed)

Don't access content document when opening new tab

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333177/

Description

Background

We are passing content document when calling openNewTabWith() for our tabs. This parameter is ignored in Firefox however. In SeaMonkey it is still being used for security checks, these should be irrelevant in our case however. Accessing content documents causes E10S trouble however.

What to change

Pass null instead of a value for the document/node parameter of openNewTabWith().

Change History (3)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Opening tabs from pages and from ABP (like the filter list homepage/list) work as expected. No warnings in the console.

ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.