Opened on 01/04/2016 at 08:20:44 PM

Closed on 01/05/2016 at 09:40:06 AM

Last modified on 01/18/2016 at 01:50:35 AM

#3465 closed change (fixed)

Don't access content document when opening new tab

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



We are passing content document when calling openNewTabWith() for our tabs. This parameter is ignored in Firefox however. In SeaMonkey it is still being used for security checks, these should be irrelevant in our case however. Accessing content documents causes E10S trouble however.

What to change

Pass null instead of a value for the document/node parameter of openNewTabWith().

Attachments (0)

Change History (3)

comment:1 Changed on 01/04/2016 at 08:23:04 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/05/2016 at 09:40:06 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed on 01/18/2016 at 01:50:35 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Opening tabs from pages and from ABP (like the filter list homepage/list) work as expected. No warnings in the console.

Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.