Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3478 closed defect (fixed)

Hide genericblock and generichide types in the composer

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333265

Description (last modified by sebastian)

How to reproduce

  1. Go to https://google.com/
  2. Right-click the Google-logo
  3. Select "Adblock Plus: Block image..."
  4. Switch into "Advanced view"

Observed behaviour

While the document is disabled (for non-whitelist filters), and elemhide isn't even exposed, genericblock and generichide can still be selected.

Expected behaviour

Hide the genericblock and generichide types in the composer, same like elemhide.

Change History (7)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:3 Changed 4 years ago by sebastian

  • Description modified (diff)

comment:4 Changed 4 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by trev

  • Cc trev added; trevgeneric removed
  • Priority changed from Unknown to P4
  • Ready set

comment:6 Changed 4 years ago by sebastian

  • Description modified (diff)
  • Summary changed from genericblock and generichide aren't disabled in the composer for blocking filters to Hide genericblock and generichide types in the composer

comment:7 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Generic types are hidden in the composer.

ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.