Opened on 01/06/2016 at 03:31:28 PM
Closed on 01/06/2016 at 03:50:16 PM
Last modified on 01/18/2016 at 01:46:17 AM
#3478 closed defect (fixed)
Hide genericblock and generichide types in the composer
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | P4 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | trev | Blocked By: | |
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description (last modified by sebastian)
How to reproduce
- Go to https://google.com/
- Right-click the Google-logo
- Select "Adblock Plus: Block image..."
- Switch into "Advanced view"
Observed behaviour
While the document is disabled (for non-whitelist filters), and elemhide isn't even exposed, genericblock and generichide can still be selected.
Expected behaviour
Hide the genericblock and generichide types in the composer, same like elemhide.
Attachments (0)
Change History (7)
comment:1 Changed on 01/06/2016 at 03:33:01 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 01/06/2016 at 03:50:16 PM by sebastian
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 01/06/2016 at 04:02:48 PM by trev
- Cc trev added; trevgeneric removed
- Priority changed from Unknown to P4
- Ready set
comment:6 Changed on 01/06/2016 at 04:56:27 PM by sebastian
- Description modified (diff)
- Summary changed from genericblock and generichide aren't disabled in the composer for blocking filters to Hide genericblock and generichide types in the composer
comment:7 Changed on 01/18/2016 at 01:46:17 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Generic types are hidden in the composer.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockplus/rev/e5302aac2aee