Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#3482 closed change (fixed)

Introduce support for HKEY_LOCAL_MACHINE

Reported by: matze Assignee:
Priority: Unknown Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords: large-scale-deployments
Cc: simona Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Rraceanu Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29347417/

Description

Last year we have introduced Windows Registry keys/options to disable automatic updates and suppress the first run page. While this works as expected, the setup has to be made for every user on the system. It should also be possible to apply these settings system-wide, in order to better support environments where workstations are shared between users.

What to change

Extend the lookup to elude to trying the HKEY_LOCAL_MACHINE\Software\AdblockPlus equivalent when the respective HKEY_CURRENT_USER\Software\AdblockPlus key/value is absent. It may make sense to apply this behavior to all lookups in a centralized fashion, though this ticket is motivated by the need to support the disable_auto_updates and suppress_first_run_page options in particular.

Change History (7)

comment:1 Changed 3 years ago by eric@…

The solution in https://codereview.adblockplus.org/29347417/ centralizes a fallback from HKCU to HKLM for all preconfiguration values in the Windows Registry.

comment:2 Changed 3 years ago by eric@…

  • Review URL(s) modified (diff)

comment:3 Changed 3 years ago by eric@…

  • Platform changed from Unknown / Cross platform to Internet Explorer
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by eric@…

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:6 Changed 3 years ago by rraceanu

  • Tester changed from Unknown to Rraceanu

comment:7 Changed 3 years ago by rraceanu

First run page or "Enabling status bar" do not trigger anymore on fresh installation, verified on IE 9 Windows 9, IE 10 Windows 8 and 8.1, IE 11 Windows 10, ABP version 1.5.856, this issue doesn't occur on released version 1.5.

Note: See TracTickets for help on using tickets.