Opened 4 years ago

Closed 3 years ago

#3487 closed change (fixed)

Finish Help tab of new options page

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1, new-settings-page
Cc: saroyanm Blocked By: #2734
Blocking: #2706 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29373674/

Description (last modified by saroyanm)

Background

In #1526 we were creating the very first version of the Help tab but there are still some changes that need to be made to finish this part of the page.

What to change

  • Implement links
    • "Frequently asked questions" should link to "faq" page
    • "Adblock Plus support forum" should link to "info.application_support" page
    • "Twitter" should link to "social_twitter"
    • "Facebook" should link to "social_facebook"
    • "Google+" should link to "social_gplus"
    • "Weibo" should link to "social_weibo"
    • "Renren" should link to "social_renren"
  • Make sure to show only relevant social media links depending on the language (as implemented in firstRun.css)

Change History (8)

comment:1 Changed 4 years ago by sebastian

  • Keywords 2016q1 added

comment:2 Changed 3 years ago by saroyanm

  • Description modified (diff)
  • Keywords new-settings-page added

We will not have link to the forum in the Help tab according to the new desing, other links still will be reusable.

comment:3 Changed 3 years ago by saroyanm

  • Cc saroyanm added

comment:4 Changed 3 years ago by saroyanm

  • Description modified (diff)

We still need link to the forum.

comment:5 Changed 3 years ago by saroyanm

  • Owner set to saroyanm

comment:6 Changed 3 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 3487 - Add links to the help tab

comment:8 Changed 3 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.