Opened 6 years ago

Closed 4 years ago

#349 closed defect (rejected)

Blocked ads numbers not shared with google plus

Reported by: philll Assignee: sven
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: Platform: Chrome
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by philll)

Environment

Chrome 34
ABP 1.7.4

How to reproduce

  1. Click on the ABP symbol
  2. Now click on share these numbers → via google plus

Observed behaviour

The numbers count is not included in the post's preview. If trying to share with Facebook, it it included in the post.

Taken from http://99tests.com/challenges/56/challengebugs/5713

Expected behaviour

The numbers count should be included in the post's preview.

Change History (16)

comment:1 Changed 6 years ago by philll

  • Description modified (diff)

comment:2 Changed 6 years ago by sebastian

  • Cc sebastian@… added

You can only share URLs (not texts) with Google Plus. But I agree that this is misleading, since the text above implies that you can share the number.

comment:3 Changed 6 years ago by philll

  • Owner set to sven
  • Status changed from new to assigned

@Sven: So should we change the text then or rather ignore this?

comment:4 Changed 6 years ago by philll

  • Status changed from assigned to new

The assigned state will be dropped by #403

comment:5 Changed 6 years ago by philll

This might be combined with #142

comment:6 Changed 6 years ago by philll

@Sven: Any news here?

comment:7 Changed 6 years ago by philll

  • Priority changed from P2 to P3

comment:8 Changed 5 years ago by philll

  • Platform set to Chrome

comment:9 Changed 5 years ago by sebastian

  • Component changed from Unknown to User-Interface

comment:10 Changed 5 years ago by sven

  • Resolution set to worksforme
  • Status changed from new to closed

known problem but google+ doesn't deliver the option to prefill the text that a user want to share. therefore we give users the option to click the g+ icon to share the numbers manually as the best solution here.

comment:11 Changed 5 years ago by philll

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Obviously not working.

comment:12 Changed 5 years ago by philll

  • Resolution set to rejected
  • Status changed from reopened to closed

...but it sounds like you decided to not change anything, so it is rejected.

comment:13 Changed 5 years ago by sven

i agree

comment:14 Changed 4 years ago by Shikitita

  • Resolution rejected deleted
  • Status changed from closed to reopened

I came across this issue when I was testing the following one from Passbrains:

https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ACH-151

After doing some research, I found this information from the Google developers' website where it seems it is possible to add prefilled text:

https://developers.google.com/+/web/share/interactive

Would it be possible to implement a preset share text as described in the website (data-prefilltext)?

comment:15 Changed 4 years ago by sebastian

  • Cc sebastian greiner added; sebastian@… removed

I'm pretty sure that this didn't exist back then. But it might be an option now.

comment:16 Changed 4 years ago by greiner

  • Resolution set to rejected
  • Status changed from reopened to closed

The linked documentation refers to Google's JavaScript API but we are currently using the "Share Link" functionality which still only allows us to specify URL and language.

Therefore we'd have to switch to the JavaScript API (e.g. within a sandboxed iFrame) which would only be possible under the condition that it can be used securely within an extension environment. In any case, this would require us to rethink how we implement the share buttons on the icon popup. That's why I'd consider it out of scope for now.

Note: See TracTickets for help on using tickets.