Opened 4 years ago

Closed 4 years ago

#3490 closed change (fixed)

Make multiprocessCompatible the default for our extensions

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333324/

Description

Background

The last E10S issues in Adblock Plus are under review. Next step would be adding <em:multiprocessCompatible> to install.rdf to mark it as fully compatible with E10S and disable compatibility shims which are only getting in the way.

What to change

Make <em:multiprocessCompatible> the new default and introduce needMultiprocessShims to metadata.gecko for the extensions still relying on shims (like Element Hiding Helper). While this approach will make upgrading somewhat more complicated as opposed to keeping the shims enabled by default, I think that most of our extensions are already E10S-compatible (Diagnostics and Customizations don't touch content) and we won't have to revert the default later on.

Change History (4)

comment:1 Changed 4 years ago by trev

  • Owner set to trev

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by trev

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.