Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3497 closed change (fixed)

Convert logging statements to Lumberjack

Reported by: pavelz Assignee:
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by pavelz)

Background

ABB and Kitt core historically used Cocoa provided NSLog() statement, which is the default and only one available logging facility. It has numerous deficits, most notably no severity level assignable.

What to change

Adopt CocoaLumberjack - done.
Walk trough the 110 of old style logging statements in Kitt core and carefully switch them over to the Lumberjack style. The event severity has to be decided on each one - the old method had not severity recognition.

Remark for testers

As this issue just covered refactoring work regarding the logging system, no usage relevant changes have been applied. Thus this change can't be verified working per se - a general QA verifying general functionality of the app is sufficient.

Exceptionally curious tester who knows Xcode and Devices inspector, can observe a change in formatting of application logging. The former format is the NSLog default:

2016-02-10 11:25:59.483 AdblockBrowser[57133:2533133] CUICatalog: Invalid asset name supplied: (null)

while the new format is more compressed

.W.|112558.609|2533133() Settings.bundle does not exist, will not register defaults

Change History (6)

comment:1 Changed 4 years ago by mario

  • Cc mario added
  • Priority changed from Unknown to P3

comment:2 Changed 4 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 4 years ago by mario

  • Description modified (diff)
  • Ready set

comment:4 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

Batch modify: added Adblock-Browser-for-iOS-next milestone.

comment:5 Changed 4 years ago by pavelz

  • Description modified (diff)

comment:6 Changed 4 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • I was able to see the change in formatting via the Device log. For example, I observed the changed format to 'W AdblockBrowser[2537] <Warning>: I |074834.620|32753() Native event '13' has no callbacks' on one event.
Note: See TracTickets for help on using tickets.