Opened 3 years ago

Last modified 20 months ago

#3501 new defect

Invalid Message shown when checking for Updates and internet connection is lost

Reported by: passbrains Assignee:
Priority: Unknown Milestone: Adblock-Plus-for-Internet-Explorer-Next
Module: Unknown Keywords:
Cc: sergz, oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29333386/
https://codereview.adblockplus.org/29333426/

Description (last modified by scheer)

Adapted from https://platform.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-125

Environment

none of assigned configurations
ABP version 1.4.798

How to reproduce

1.Install ABP on IE11
2.Now remove the Internet connection or disable the wifi
3.Click on "Check for Updates" on ABP icon

Observed behaviour

The message shown is incorrect is shown is having as "The Error text was ?1?..

Expected behaviour

The Message shown should be proper

Attachments (1)

13317_1447756925_Untitled.jpg (157.7 KB) - added by passbrains 3 years ago.

Download all attachments as: .zip

Change History (7)

Changed 3 years ago by passbrains

comment:1 Changed 3 years ago by scheer

  • Cc sergz oleksandr added
  • Description modified (diff)

comment:2 Changed 3 years ago by sergz

  • Review URL(s) modified (diff)

There are actually two bugs:

  1. The title string is incorrect, the text string is used as the title string [in review].
  2. We basically don't have an error description, so ?1? is not replaced by anything.

Should we just drop The error text was: ?1??

https://github.com/adblockplus/new-adblockplusie/blob/master/locales/en.ini#L19

comment:3 Changed 3 years ago by oleksandr

I think it would be better to output "Unknown error" or something like that. Maybe we will have an error text in some cases in future.

comment:4 Changed 3 years ago by sergz

  • Review URL(s) modified (diff)

comment:5 Changed 21 months ago by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next

comment:6 Changed 20 months ago by oleksandr

  • Milestone changed from Adblock-Plus-for-Internet-Explorer-1.6 to Adblock-Plus-for-Internet-Explorer-Next
Note: See TracTickets for help on using tickets.