Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3502 closed change (fixed)

Don't use expression closures in Issue Reporter

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333389/

Description

Background

Issue reporter is using expression closures for some getters. These are deprecated and generate warnings in Firefox 46.

What to change

Replace expression closures by normal functions.

Change History (3)

comment:1 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

No warning appears in the Firefox console.

ABP 2.7.0.4128-beta
Firefox 46.0a1 / Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.