Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3503 closed defect (fixed)

Screenshot marker in Issue Reporter is no longer red

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333400/

Description

Environment

Adblock Plus 2.7.0.4123-beta

How to reproduce

  1. Click ABP icon and "Report issue on this page" on some website.
  2. Choose "Adblock Plus doesn't block an advertisement" in Issue Reporter and click Continue.
  3. Click somewhere in the screenshot and drag.

Observed behaviour

A black frame is being drawn, line width 1 pixel.

Expected behaviour

A red frame is being drawn, line width 3 pixels.

Background

This is a regression from #3486. Canvas context is initialized before canvas size is set. It seems that setting canvas size resets everything however.

Change History (3)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Frame is red again.

ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.