Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3505 closed change (fixed)

Issue reporter calls String.replace() with deprecated flags parameter

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29333409/

Description

Background

Issue reporter calls String.replace() with a string to replace and "gi" as flags parameter. The flags parameter is deprecated however and causes a warning in Firefox 46.0a1.

What to change

Convert the string into a proper regular expression, so that no flags have to be passed to String.replace().

Change History (4)

comment:1 Changed 4 years ago by trev

  • Summary changed from Issue reporter uses deprecacted flags parameter to String.replace() to Issue reporter calls String.replace() with deprecated flags parameter

comment:2 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

No warning appears in the Firefox console.

ABP 2.7.0.4128-beta
Firefox 46.0a1 / Ubuntu 14.04 x64

Note: See TracTickets for help on using tickets.