Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3525 closed change (fixed)

Add possibility for testers to crash application

Reported by: mario Assignee:
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords: salsita
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by mario)

Background

#3272 introduced a crash reporter and #3436 extends its functionality by more configuration options. In order to perform proper QA for #3436 (and other upcoming issues related to crashes/crash reports) we need to be able to reliably crash the application. Thus we'd like to introduce said option which is only visible for development builds.

What to change

  1. Add a new button labeled "Crash Application Now" at the bottom of the crash report settings screen (Settings -> Crash Report)
  2. Tapping this button causes the App to immediately crash, triggering a crash report.

Special Requirements

  1. Make this button/functionality only available in development builds. It must never be visible in release builds.
  2. Make the crash report distinguishable from other crash reports in regard to content so it cannot be confused with real crash reports.

Change History (9)

comment:1 Changed 4 years ago by mario

  • Description modified (diff)

comment:2 Changed 4 years ago by jand

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

Batch modify: added Adblock-Browser-for-iOS-next milestone.

comment:4 Changed 4 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

Above it states -

'Add a new button labeled "Crash Application Now" at the bottom of the crash report settings screen (Settings -> Crash Report)'

But, the test crash option in the app actually states 'Generate Test Crash'. Is 'Generate Test Crash' or 'Crash Application Now' the correct text?

Also stated is -

'Make this button/functionality only available in development builds. It must never be visible in release builds.'

I would not be able to check this until this feature went live, of course. Could I ask how it will be removed during the release process? Will there be some sort of check put in place for this to be looked at? A reminder?

Also -

'Make the crash report distinguishable from other crash reports in regard to content so it cannot be confused with real crash reports.'

Here, it would be great to have some idea of how to identify these. Is there some particular wording that is shown in some particular area of the crash report?

comment:5 Changed 4 years ago by mario

  • Ready set

comment:6 Changed 4 years ago by jand

I fixed wrong title. Crash report generated by this button can be easily recognised in HockeyApp.

If the crash button will make to production, it will not be working, since this hockeyApp functionality is disabled in App Store.

@mario: Do you want to localize this button? I think it does not make sense so that I made it unlozalizable.

comment:7 Changed 4 years ago by mario

No objections, as this will always only be available in devbuilds.

If the crash button will make to production, it will not be working [...]

We need to make sure that this can't ever happen. Even though it wouldn't function, this feature is meant to be displayed in devbuilds only.

comment:8 Changed 4 years ago by jand

  • Resolution set to fixed
  • Status changed from reopened to closed

Pavel must use release configuration during creation of release build, but it created by default, so it should be ok.

comment:9 Changed 4 years ago by scheer

  • Verified working set

@Mario - I would say we need something in place to check the release build before it hits the App Store for this then.

  • The 'Crash Application Now' button now correctly crashes the app and sends a report to HockeyApp.

ABB 1.3.0-qa (824)
iPhone 6 Plus - iOS 9.2.1

Note: See TracTickets for help on using tickets.