Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3528 closed change (fixed)

Integrate updated ABP bundle with self contained ABB API

Reported by: pavelz Assignee: pavelz
Priority: P2 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario, fhd Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description

Background

ABB integration with ABP bundle was done by injecting an api JS snippet into already existing ABP background script. The snippet was part of ABB native bundle, not the ABP crx bundle. That brings great flexibility in developing/fixing the integration against a stable ABP crx, but basically prevents simple crx updates. Now that the integration is reasonably stable, crx updatability is more important than easy hackability. The standalone snippet must become an integral testable part of the crx.

What to change

Remove ABB logic for injecting a standalone api.js on the native side.
Change ABB logic to work with the new api.js bundled with ABP crx.

Testing

Verify that all ABP bundle integration points keep working normally. The browser should behave as expected according to the settings (acceptable ads, whitelisting, etc.) Switches changed in any native browser screen must stay in the changed state when the screen is left and entered again.

  • enable/disable whitelisting in main browser menu
  • add/remove language subscriptions
  • more blocking options
  • acceptable ads on/off
  • removing whitelisted site

Change History (6)

comment:1 Changed 4 years ago by pavelz

  • Cc mario fhd added
  • Component changed from Unknown to Adblock-Browser-for-iOS
  • Keywords blocked added
  • Owner set to pavelz
  • Platform changed from Unknown / Cross platform to Adblock Browser for iOS

comment:2 Changed 4 years ago by pavelz

Blocked by bug in roundtrip getWhitelistedSites -> whitelistSite(url, false). Discussed with @fhd over email

comment:3 Changed 4 years ago by pavelz

  • Milestone set to Adblock-Browser-for-iOS-next
  • Priority changed from Unknown to P2

comment:4 Changed 4 years ago by pavelz

  • Keywords blocked removed
  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 4 years ago by mario

  • Ready set

comment:6 Changed 4 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • You are able to enable and disable whitelisting
  • You can remove and add subscription languages
  • You can enable and disable 'More Blocking Options'
  • You can enable and disable Acceptable Ads
  • You are able to remove whitelisted sites

ABB 1.3.0 (814)
iPhone 5C 16 GB - iOS 9.2.1

Note: See TracTickets for help on using tickets.