Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#3538 closed defect (fixed)

Filter listener tests fail for CSS property rules

Reported by: trev Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29336495/

Description (last modified by trev)

Environment

Adblock Plus 2.7.1, Firefox 46.0a1 nightly

How to reproduce

  1. Run filterListener unit tests.

Observed behaviour

Unit tests fail to detect CSS property rules that have been added, claiming that none have been. This is yet another fallout from bug 1202902, variable filters in cssRules.js isn't global.

Expected behaviour

Unit tests should run through correctly.

Hints for testers

This shouldn't have any visible effects in the product whatsoever. The dependency update also imported the fix for #3612 from adblockpluscore which only touches comments. Also, changes for #3654, #3618 and #2598 have been imported, these don't touch any files used in Adblock Plus for Firefox however.

Change History (4)

comment:1 Changed 3 years ago by trev

  • Owner set to trev

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-2.7.2-for-Firefox
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Marking verified as changes have not caused any adverse effects / ABP is still working as expected.

ABP 2.7.2
Firefox 38.0 / Firefox 46.0a1 (Nightly) / Ubuntu 14.04 x64
Firefox 38.0 / Firefox 43.0.1 / Firefox 46.0a1 (Nightly) / Windows 7 x64

Note: See TracTickets for help on using tickets.