Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#354 closed defect (fixed)

Avoid toUpperCase call in filters

Reported by: tschuster Assignee: tschuster
Priority: P2 Milestone: Adblock-Plus-2.6-for-Firefox
Module: Core Keywords:
Cc: Blocked By: #419
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5150730151264256/

Description

That toUpperCase causes us to keep around the string twice. Once the original and once as upper-case. But we really only need it when something invokes the domain getter.

Change History (7)

comment:2 Changed 5 years ago by tschuster

  • Owner set to tschuster
  • Status changed from new to assigned

comment:3 Changed 5 years ago by tschuster

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 Changed 5 years ago by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed 4 years ago by trev

  • Component changed from Adblock-Plus-for-Firefox to Core

comment:6 Changed 4 years ago by trev

  • Blocked By 419 added

comment:7 Changed 4 years ago by tschuster

I tried to measure how much this actually helped, but sadly the string memory usage is so random it's hard to tell.

Note: See TracTickets for help on using tickets.