Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3549 closed defect (fixed)

[ABP for iOS] [Settings] Misaligned text in Arabic

Reported by: Shikitita Assignee: jand
Priority: P2 Milestone: Adblock-Plus-for-iOS-1.1.0
Module: Adblock-Plus-for-iOS/macOS Keywords: salsita
Cc: pavelz, jand, mario Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Shikitita Verified working: yes
Review URL(s):

https://github.com/adblockplus/adblockplussafariios/pull/24

Description

Environment

Platform: iPhone 6
Operating system: iOS 9.1
App: Adblock Plus for iOS v 1.0.1 (201601191756)

How to reproduce

  1. Install Adblock Plus for iOS for the first time
  2. Change the iPhone's language into Arabic
  3. Access Adblock Plus for iOS by tapping on its icon in the Home screen
  4. After going through the onboarding slides, tap on the Settings icon at the bottom of the screen
  5. Tap on "Acceptable Ads" (الإعلان المقبول)

Observed behaviour

The string "Allow some nonintrusive ads" (السماح ببعض الإعلانات الغير متطفلة) is misaligned towards the left and concatenated with the prompt button.

Expected behaviour

The string "Allow some nonintrusive ads" should be aligned towards the right so that in can be read properly as well as being visually appealing.

Note that this happens with all the strings with a prompt button as can be seen in the attached screenshots.

Attachments (2)

IMG_0004.PNG (68.7 KB) - added by Shikitita 4 years ago.
Arabic AA misalignment
IMG_0005.PNG (86.9 KB) - added by Shikitita 4 years ago.
Arabic Settings Misalignment

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by Shikitita

Arabic AA misalignment

Changed 4 years ago by Shikitita

Arabic Settings Misalignment

comment:1 Changed 4 years ago by mario

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed 4 years ago by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by fhd

  • Owner set to jand

comment:4 Changed 4 years ago by fhd

  • Milestone set to Adblock-Plus-for-iOS-1.1.0
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 4 years ago by Shikitita

  • Verified working set
Note: See TracTickets for help on using tickets.