Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3553 closed defect (fixed)

Back/fwd navigation is not updating URL bar for pages created by HTML5 history

Reported by: pavelz Assignee:
Priority: P2 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by mario)

Environment

Adblock Browser 1.2.1
Any device

How to reproduce

  1. Open new clean tab without any history
  2. Open any generic page, e.g. https://acceptableads.org
  3. Open specific page http://html5demos.com/history
  4. Click on "first" link
  5. Click back arrow

Observed behaviour

In step 4. URL should be replaced with http://html5demos.com/history/first (this can be broken too!)
In step 5. URL is NOT turned back to http://html5demos.com/history

Expected behaviour

In step 4. URL is always http://html5demos.com/history/first
In step 5. URL is always http://html5demos.com/history

Change History (11)

comment:1 Changed 4 years ago by pavelz

The culprit is in the fact that walking HTML5-created history with virtual URLs does not fire any events in the iOS webview native interfaces, so the browser essentialy does not know what is the next URL to display. A possible solution is to remember HTML5 flag when the history is being created, and force assign the already known URL when such page is encountered. This would require changing browser data model.

comment:2 Changed 4 years ago by mario

  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 4 years ago by mario

  • Description modified (diff)

comment:5 Changed 4 years ago by pavelz

  • Keywords dbchange added

comment:6 Changed 4 years ago by jand

  • Keywords dbchange removed
  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

comment:8 Changed 4 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer

ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1

comment:9 Changed 4 years ago by pavelz

  • Cc mario added
  • Milestone Adblock-Browser-for-iOS-next deleted
  • Resolution set to fixed
  • Status changed from reopened to closed

The issue has "next release" milestone assigned prematurely. The functionality is fixed in develop branch and is not a part of the current 1.3.0 release branch.

comment:10 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

Rebased the current release branch to include this ticket.

comment:11 Changed 4 years ago by scheer

  • Verified working set

ABB 1.3.0-qa (844)
iPhone 6 Plus - iOS 9.2.1

Note: See TracTickets for help on using tickets.