Opened 4 years ago

Last modified 4 years ago

#3574 closed change

Refactor Puppet class base into class adblockplus — at Initial Version

Reported by: matze Assignee:
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334668
https://codereview.adblockplus.org/29334690
https://codereview.adblockplus.org/29335885
https://codereview.adblockplus.org/29337881
https://codereview.adblockplus.org/29339094
https://codereview.adblockplus.org/29337931
https://codereview.adblockplus.org/29338036
https://codereview.adblockplus.org/29338473
https://codereview.adblockplus.org/29340814
https://codereview.adblockplus.org/29366707
https://codereview.adblockplus.org/29366882
https://codereview.adblockplus.org/29366987

Description

Class base is always included by our node classifier, never by any other Puppet class. Thus the movement itself should be fairly trivial, though we may consider additional improvements now, i.e.:

  • Remove the possibly obsolete conditional around the definition of class apt
  • Avoid all explicit host records being realized due to Puppet issue 4145

Desired future improvements include:

  • Avoid APT update being executed on every single Puppet run
  • Remove private::users in favour of $adblockplus::users
  • Improve the node classifier, especially handling of Hiera/$servers parameters
  • Migrate base::explicit_host_record() into class adblockplus::host

This ticket is part of our long-term adventure of improving the infrastructure code-base.

Change History (0)

Note: See TracTickets for help on using tickets.