Opened 5 years ago

Last modified 4 years ago

#3574 closed change

Refactor Puppet class base into class adblockplus — at Version 5

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: #3576, #3587 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


Class base is always included by our node classifier, never by any other Puppet class. Thus the movement itself should be fairly trivial, though we may consider additional improvements now, i.e.:

  • Remove the possibly obsolete conditional around the definition of class apt
  • Avoid all explicit host records being realized due to Puppet issue 4145

Desired future improvements include:

  • Avoid APT update being executed on every single Puppet run
  • Remove private::users in favour of $adblockplus::users
  • Improve the node classifier, especially handling of Hiera/$servers parameters
  • Migrate base::explicit_host_record() into class adblockplus::host

This ticket is part of our long-term adventure of improving the infrastructure code-base.

Change History (5)

comment:1 Changed 5 years ago by matze

  • Blocking 3576 added
  • Cc fred removed
  • Ready set

comment:2 Changed 5 years ago by matze

  • Blocking 3587 added

comment:3 Changed 5 years ago by matze

  • Owner set to matze

comment:4 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

In order to remove blocking status for #3587, the first step is a simple inclusion of class base within class adblockplus (and updating base.yaml accordingly).

comment:5 Changed 5 years ago by matze

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.