Opened 4 years ago

Last modified 3 years ago

#3575 reviewing change

Improve Puppet module logrotate

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: #3576 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340810/

Description (last modified by matze)

Extend modules/logrotate by the obligatoric but missing documentation bits, and address the minor inconsistencies with our style guide.

Change History (4)

comment:1 Changed 4 years ago by matze

  • Blocking 3576 added
  • Cc fred removed
  • Ready set

comment:2 Changed 4 years ago by matze

  • Description modified (diff)
  • Owner set to matze
  • Summary changed from Refactor Puppet class logrotate into class adblockplus::log to Improve Puppet module logrotate

After some reconsideration, we came to the conclusion that module logrotate already fits our general requirements quite well; integrating the software itself and allowing for specialization within other Puppet modules. Hence it should be enough if the resource definition moves from class base to class adblockplus::log (see #3574) to comply with the goals from #3576.

Still there are some tasks necessary before we can consider the logrotate integration compliant with our requirements. Especially documentation and punctuation requires some minor improvements, which can be done in the context of this ticket instead.

comment:3 Changed 3 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/4481a7bba9ca

Note: See TracTickets for help on using tickets.