Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3584 closed defect (fixed)

[abp2blocklist] Element hiding rules with uppercase letters never apply

Reported by: sebastian Assignee: kzar
Priority: P2 Milestone:
Module: Platform Keywords: 2016q1
Cc: kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29336525/

Description (last modified by kzar)

Background

If a rule's action.type is css-display-none and it's action.selector is a CSS selector that matches by ID using uppercase letters (e.g. #FooBar), it should hide elements like <div id="FooBar">. But due to a WebKit bug, that doesn't work.

If we use the attribute syntax like [id=FooBar] however it _does_ work, the rule will hide the element.

What to change

For each hiding rule, modify the selector to ensure that all IDs are specified with the [id=FooBar] syntax instead of the normal #FooBar syntax.

Change History (5)

comment:1 Changed 4 years ago by kzar

  • Owner set to kzar

comment:2 Changed 4 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 years ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 4 years ago by kzar

  • Description modified (diff)
  • Summary changed from [abp2blocklist] element hiding rules with uppercase letters never apply to [abp2blocklist] Element hiding rules with uppercase letters never apply

comment:5 Changed 4 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.