Opened 3 years ago

Closed 3 years ago

#3587 closed change (fixed)

Refactor Puppet class users into type adblockplus::user

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: #3576 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29334658
https://codereview.adblockplus.org/29334693
https://codereview.adblockplus.org/29335877
https://codereview.adblockplus.org/29335882
https://codereview.adblockplus.org/29338467
https://codereview.adblockplus.org/29339079

Description (last modified by matze)

With the introduction of parameter $adblockplus::users and type adblockplus::user in #3508, Puppet class users has been declared deprecated. The new one is currently implemented as a wrapper around the old, thus the first task will be migrating existing user accounts - before moving the actual code.

Change History (13)

comment:1 Changed 3 years ago by matze

  • Owner set to matze
  • Ready set

comment:2 Changed 3 years ago by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by matze

  • Blocked By 3574 added
  • Blocking 3576 added

comment:4 Changed 3 years ago by matze

  • Review URL(s) modified (diff)

comment:6 Changed 3 years ago by matze

  • Review URL(s) modified (diff)

comment:7 Changed 3 years ago by matze

  • Type changed from defect to change

comment:9 Changed 3 years ago by matze

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Summary changed from Refactor Puppet class users into class adblockplus::user to Refactor Puppet class users into type adblockplus::user

comment:10 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/740cdf91d910

comment:11 Changed 3 years ago by matze

  • Review URL(s) modified (diff)

All remaining resources in Class['users'] are related to super-user access:

  • File['/etc/sudoers.d/puppet']
  • File['/root/.ssh/authorized_keys']
  • User['root']

For those we'll introduce a "mixin" class adblockplus::sudo, transferring each file resources as-is, but replacing User['root'] (which ensures no password being set) with an ensure_dependencies() equivalent.

comment:12 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/3d68e0339734

comment:13 Changed 3 years ago by matze

  • Blocked By 3574 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.