Changes between Initial Version and Version 1 of Ticket #3593


Ignore:
Timestamp:
01/29/2016 10:34:03 AM (4 years ago)
Author:
sergz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3593 – Description

    initial v1  
    1313There is also another issue #1197 which is more important than this one right now. That issue also requires to switch from using `v8::Isolate::GetCurrent()` to `v8::Isolate::New()` which is a part of the current issue. 
    1414- With the updated v8 (according to #1197) we cannot simply use that approach because 32bit version of tests starting from some point runs out of memory, 64 bit version works. 
     15 
     16  The callstack 
     17{{{ 
     18>       tests.exe!v8::base::RandomizedVirtualAlloc(unsigned int size, int action, int protection) Line 758      C++ 
     19        tests.exe!v8::base::VirtualMemory::ReserveRegion(unsigned int size) Line 1254   C++ 
     20        tests.exe!v8::base::VirtualMemory::VirtualMemory(unsigned int size, unsigned int alignment) Line 1190   C++ 
     21        tests.exe!v8::internal::MemoryAllocator::ReserveAlignedMemory(unsigned int size, unsigned int alignment, v8::base::VirtualMemory * controller) Line 394 C++ 
     22        tests.exe!v8::internal::NewSpace::SetUp(int reserved_semispace_capacity, int maximum_semispace_capacity) Line 1232      C++ 
     23        tests.exe!v8::internal::Heap::SetUp() Line 5464 C++ 
     24        tests.exe!v8::internal::Isolate::Init(v8::internal::Deserializer * des) Line 1992       C++ 
     25        tests.exe!v8::internal::Snapshot::Initialize(v8::internal::Isolate * isolate) Line 52   C++ 
     26        tests.exe!v8::Isolate::New(const v8::Isolate::CreateParams & params) Line 6631  C++ 
     27        tests.exe!AdblockPlus::ScopedV8Isolate::ScopedV8Isolate() Line 76       C++ 
     28        tests.exe!std::_Ref_count_obj<AdblockPlus::ScopedV8Isolate>::_Ref_count_obj<AdblockPlus::ScopedV8Isolate><>() Line 932  C++ 
     29        tests.exe!std::make_shared<AdblockPlus::ScopedV8Isolate>() Line 1003    C++ 
     30        tests.exe!AdblockPlus::JsEngine::New(const AdblockPlus::AppInfo & appInfo, const std::shared_ptr<AdblockPlus::ScopedV8Isolate> & isolate) Line 94       C++ 
     31... 
     32}}} 
     33  parameters are: 33554432 == 32 * 2^20^, MEM_RESERVE, PAGE_NOACCESS, `base` is nullptr. 
     34  GetLastError() == 8, "Not enough storage is available to process this command". 
     35 
    1536- With the current version of v8 we also cannot simply use it, I suppose because during the allocation of a new isolate v8 finds another one stored in the current TLS, which results in some internal conflict. 
    1637