Changes between Version 3 and Version 7 of Ticket #3593


Ignore:
Timestamp:
01/11/2017 01:27:43 PM (3 years ago)
Author:
eric@…
Comment:

Review https://codereview.adblockplus.org/29370977/, possible after rewriting all the thread management in the library, removes the shared isolate used in tests. Some of the tests need some rework to deal with a "feature" of Google Test: you can't rely on the test destructor to release memory in a timely fashion. On my machine, the test suite completes without running out of memory.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3593

    • Property Status changed from new to reviewing
    • Property Blocked By changed from 3594, 3595 to 3594, 3595, 4688, 4692, 4788
  • Ticket #3593 – Review URL(s)

    v3 v7  
    11https://codereview.adblockplus.org/6233220328718336/ 
     2https://codereview.adblockplus.org/29370977/