Opened 4 years ago

Closed 3 years ago

Last modified 2 years ago

#3594 closed defect (fixed)

The circular reference problem, JsEngine<>-JsValue<>-JsEngine

Reported by: sergz Assignee: sergz
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: fhd, rjeschke, oleksandr, eric@…, Anton Blocked By: #4613
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29361562/
https://codereview.adblockplus.org/29365532/

Description

Background

The circular reference problem. AdblockPlus::JsEngine has member JsValuePtr globalJsObject; which has JsEnginePtr jsEngine; member.

What to change

Get rid of that circular reference.

Change History (7)

comment:1 Changed 3 years ago by sergz

  • Owner set to sergz

comment:2 Changed 3 years ago by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by asmirnov

  • Cc Anton added

comment:4 Changed 3 years ago by sergz

  • Blocked By 4613 added

comment:5 Changed 3 years ago by eric@…

  • Review URL(s) modified (diff)

comment:6 Changed 3 years ago by eric@…

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 2 years ago by sergz

  • Blocking 3593 removed
Note: See TracTickets for help on using tickets.