Opened 4 years ago

Closed 4 years ago

#3597 closed defect (fixed)

basic view / advanced view broken in EHH 1.3.6.521

Reported by: mapx Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.7
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev, greiner, erikvold Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29336275/

Description (last modified by mapx)

Environment

windows 10
FF 45.0b1
ABP 2.7.1.4132
EHH 1.3.6.521

How to reproduce

go to whatever site
click select an element to hide
(I was using EHH in "advanced view" modality)
in the composer window click "Basic view" button

Observed behaviour

the button is unresponsive

Expected behaviour

clicking the button should switch between basic / advanced view

Change History (7)

comment:1 Changed 4 years ago by mapx

  • Description modified (diff)

comment:2 Changed 4 years ago by mapx

  • Summary changed from basic view / advanced view broken in EHH to basic view / advanced view broken in EHH 1.3.6.521

comment:3 Changed 4 years ago by mapx

I use EHH in a new installation and I'm forced to "basic view" settings in EHH.
There are broken both stable and dev build.

comment:4 Changed 4 years ago by mapx

errors in console

ReferenceError: advancedMode is not defined
anonymous()
 dialog.xml line 378 > Function:1
_fireButtonEvent()
 dialog.xml:379
_doButtonCommand()
 dialog.xml:347
_handleButtonCommand()
 dialog.xml:335
 dialog.xml line 378 > Function:1:17

Last edited 4 years ago by mapx (previous) (diff)

comment:5 Changed 4 years ago by trev

  • Owner set to trev
  • Priority changed from Unknown to P1
  • Ready set

Ouch, I was certain that we fixed that one a while ago... Yet another fallout from https://bugzilla.mozilla.org/show_bug.cgi?id=1202902.

comment:6 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 4 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.