Opened on 01/31/2016 at 07:23:58 AM

Closed on 02/11/2016 at 04:16:52 PM

#3597 closed defect (fixed)

basic view / advanced view broken in EHH

Reported by: mapx Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.7
Module: Extensions-for-Adblock-Plus Keywords:
Cc: trev, greiner, erikvold Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mapx)


windows 10
FF 45.0b1

How to reproduce

go to whatever site
click select an element to hide
(I was using EHH in "advanced view" modality)
in the composer window click "Basic view" button

Observed behaviour

the button is unresponsive

Expected behaviour

clicking the button should switch between basic / advanced view

Attachments (0)

Change History (7)

comment:1 Changed on 01/31/2016 at 11:27:05 AM by mapx

  • Description modified (diff)

comment:2 Changed on 01/31/2016 at 11:27:33 AM by mapx

  • Summary changed from basic view / advanced view broken in EHH to basic view / advanced view broken in EHH

comment:3 Changed on 02/11/2016 at 03:01:09 PM by mapx

I use EHH in a new installation and I'm forced to "basic view" settings in EHH.
There are broken both stable and dev build.

comment:4 Changed on 02/11/2016 at 03:06:27 PM by mapx

errors in console

ReferenceError: advancedMode is not defined
 dialog.xml line 378 > Function:1
 dialog.xml line 378 > Function:1:17

Last edited on 02/11/2016 at 03:09:48 PM by mapx

comment:5 Changed on 02/11/2016 at 03:58:44 PM by trev

  • Owner set to trev
  • Priority changed from Unknown to P1
  • Ready set

Ouch, I was certain that we fixed that one a while ago... Yet another fallout from

comment:6 Changed on 02/11/2016 at 04:01:53 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 02/11/2016 at 04:16:52 PM by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.