Opened 4 years ago
Closed 4 years ago
#3612 closed change (fixed)
Fix `typeMask` parameter type in functions description
Reported by: | sergz | Assignee: | kzar |
---|---|---|---|
Priority: | P4 | Milestone: | |
Module: | Core | Keywords: | |
Cc: | kzar, trev | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by kzar)
Background
It seems introduced in #2738. Currently it says
@param {String} typeMask bitmask of content / request types to match
should be
@param {number} typeMask bitmask of content / request types to match
So far, it's incorrect for RegExpFilter.prototype.matches and for Matcher.prototype.matchesAny.
What to change
Change the description and ensure there are no other places.
Change History (4)
comment:1 Changed 4 years ago by kzar
- Description modified (diff)
- Owner set to kzar
- Priority changed from Unknown to P4
- Ready set
comment:2 Changed 4 years ago by kzar
- Cc trev added
comment:3 Changed 4 years ago by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed 4 years ago by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluscore/rev/99f47c269a9d