Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3624 closed defect (fixed)

Scroll bar overlaps the 'Close' button in 'Filter List' when 'Vertical Layout' is enabled in 'Customizations for Adblock Plus'

Reported by: passbrains Assignee: trev
Priority: P4 Milestone: Customizations-1.0.5-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: scheer, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Scheer Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29335559/

Description (last modified by trev)

Adapted from https://platform.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-242

When the user enables the 'Vertical Layout' in 'Customisations for Adblock Plus', the scroll bar in 'Filter Lists' overlaps the 'Close' button when the window is resized.

Environment

Windows + 8 64bit + Firefox + English
ABP version 2.7.1.4134-beta

How to reproduce

  1. Install ABP plugin.
  2. Install "Customization for Adblock Plus" add-on.
  3. Open options of "Customization for Adblock Plus".
  4. Enable "Vertical layout" option under "Filter Preferences customizations".
  5. Click on ABP icon and choose "Filter preferences...".
  6. Click on down cursor of scroll bar.

Observed behaviour

Filter preferences dialog is closed as scroll bar is overlapped with 'close' button.

Expected behaviour

You are able to scroll through filters.

Background

The problem here isn't really the scroll bar, it's rather that the height of the bottom pane is so small it's unusable.

Attachments (1)

3766_1454401981_ffVerLay.png (77.2 KB) - added by passbrains 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by scheer

  • Cc scheer trev added
  • Description modified (diff)
  • Summary changed from In vertical layout of ABP, scroll bar is overlapped with 'close' button. to Scroll bar overlaps the 'Close' button in 'Filter List' when 'Vertical Layout' is enabled in 'Customizations for Adblock Plus'

comment:2 Changed 4 years ago by scheer

Reproduced in Firefox 42, ABP 2.7.1, Customisations for Adblock Plus 1.0.4.

Last edited 4 years ago by scheer (previous) (diff)

Changed 4 years ago by passbrains

comment:3 Changed 4 years ago by trev

  • Component changed from Unknown to Extensions-for-Adblock-Plus
  • Description modified (diff)
  • Owner set to trev
  • Priority changed from Unknown to P4
  • Ready set

comment:4 Changed 4 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 4 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester changed from Unknown to Scheer

Fixed in Customizations extension: https://hg.adblockplus.org/abpcustomization/rev/9762e6d854ed. Please verify that this is sufficient to fix the issue on Windows 8.

comment:6 Changed 4 years ago by trev

  • Milestone set to Customizations-1.0.5-for-Adblock-Plus
Note: See TracTickets for help on using tickets.