Changes between Version 7 and Version 12 of Ticket #3638


Ignore:
Timestamp:
04/28/2016 01:01:17 AM (3 years ago)
Author:
matze
Comment:

The last remaining direct invocation of hiera('servers') outside of class base is in the sitescripts.ini template for the stats-master. We can easily migrate the template magic using the newly introduced adblockplus::host::$role mechanism and conditional sitescripts::configfragment definitions, but there are a few other prerequisites which we need to address before:

  • Migrate the node definition from the statsserver.pp manifest into a Hiera role
  • Migrate the node definitions from the downloadserver.pp manifest into a Hiera role
  • Migrate the node definition from the updateserver.pp manifest into a Hiera role
  • Finally fix the global Host[] and Sshkey[] realization introduced by accident

The first and last points are covered by the recent patch-set. Note that the latter requires the removal of the resulting configuration fragments in production after it has landed, which could become quite some effort if not done in automated fashion (more later).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3638

    • Property Blocking changed from 6, 1462, 1568, 3305, 3576, 3669 to 6, 1462, 1568, 3305, 3576, 3770
  • Ticket #3638 – Review URL(s)

    v7 v12  
    11https://codereview.adblockplus.org/29338046/ 
    22https://codereview.adblockplus.org/29338054/ 
     3https://codereview.adblockplus.org/29340915/