Opened 3 years ago

Closed 2 years ago

#3642 closed change (worksforme)

Unstick Adblock Browser Notification

Reported by: mario Assignee: ashephard
Priority: P3 Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords: salsita
Cc: Blocked By:
Blocking: Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mario)

Background

If you open Adblock Plus for iOS on a device where Adblock Browser for iOS isn't installed, the App will show a notification at the bottom of the settings screen. On smaller displays (iPhone 5) this notification overlays the bottom settings items due to the fact that we added numerous new items for the new release as shown in this screenshot.
These items are now hard to reach which is why we want to unstick this notification and make it part of the scrollable content.

What to change

Make the Adblock Browser notification in the settings screen part of the content.

  • It shouldn't be sticky anymore and shouldn't overlay settings items.
  • Thus is should be displayed as the last item in the settings screen (below the "More" item) and move with the rest of the content while scrolling.

Remark for testers

This can only be tested on an iPhone 5. iPhone 6 and above have bigger screens and thus more space for content. The overlapping only happens on smaller screens as shown in this screenshot.
Also you need to make sure that Adblock Browser for iOS isn't installed for the notification to be shown.

Attachments (3)

abp_abb_notice.png (83.8 KB) - added by mario 3 years ago.
Simulator Screen Shot 14 Aug 2017, 15.52.43.png (104.4 KB) - added by ashephard 2 years ago.
Screenshot of iPhone SE demonstrating fully visible About button.
Simulator Screen Shot 15 Aug 2017, 14.52.03.png (95.2 KB) - added by ashephard 2 years ago.
Increased number of table view options. Banner is not blocking any of possible table view options.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 years ago by mario

  • Component changed from Adblock-Browser-for-iOS to Adblock-Plus-for-iOS
  • Platform changed from Adblock Browser for iOS to iOS

Changed 3 years ago by mario

comment:2 Changed 3 years ago by mario

  • Description modified (diff)

comment:3 Changed 3 years ago by mario

  • Ready set

comment:4 Changed 3 years ago by mario

  • Priority changed from Unknown to P3

comment:5 Changed 2 years ago by ashephard

  • Owner set to ashephard

comment:6 Changed 2 years ago by ashephard

The content isn't hidden behind the Adblock Browser notification label. The user has the ability to scroll the view and the 'About' option is fully visible. Would advise for the ticket to be closed. See attached image. Tested on iPhone SE (Same aspect/screen size as iPhone 5).

Changed 2 years ago by ashephard

Screenshot of iPhone SE demonstrating fully visible About button.

comment:7 Changed 2 years ago by mario

@ashephard, with #3241 and later on #4661 we'll introduce additional settings items, which will eventually push the bottom most item under the notification about ABB. Installing the current devbuild (containing #3241) on an iPhone SE should already result in this.

comment:8 Changed 2 years ago by ashephard

@mario I've checked the latest dev build and also added more options to the table view for testing this. The notification banner doesn't overlap with any of the table view settings (see attachment). Nothing needs to be edited code-wise, would recommend closing this ticket.

Changed 2 years ago by ashephard

Increased number of table view options. Banner is not blocking any of possible table view options.

comment:9 Changed 2 years ago by mario

  • Resolution set to worksforme
  • Status changed from new to closed

It appears like this was unintentionally fixed while introducing other changes to the settings overview. Rejecting this change for now, but keeping it on the radar, just in case.

Note: See TracTickets for help on using tickets.