Opened 4 years ago

Closed 4 years ago

#3644 closed defect (fixed)

Favicon displayed in empty tabs

Reported by: mario Assignee:
Priority: P2 Milestone: Adblock-Browser-for-iOS-1.3.0
Module: Adblock-Browser-for-iOS Keywords: salsita
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description (last modified by mario)

Environment

iPhone 6
iOS 9.2
ABB 1.3.0-QA

How to reproduce

  1. Open ABB
  2. Open a new (empty) tab
  3. Please notice that there is no favicon displayed in the tabs menu as shown in this screenshot
  4. Navigate to adblockplus.org
  5. Please notice that now there is a favicon displayed in the tabs menu as shown in this screenshot
  6. Navigate back to the dashboard using browser back (or swipe gestures)

Observed behaviour

The favicon of the previously visited site is still displayed for the currently empty tab in the tabs menu as shown in this screenshot.

Expected behaviour

No favicon should be displayed for empty tabs in the tabs menu as shown in this screenshot.

Attachments (3)

ABB_favicon_1.PNG (23.6 KB) - added by mario 4 years ago.
ABB_favicon_2.PNG (48.0 KB) - added by mario 4 years ago.
ABB_favicon_3.PNG (24.2 KB) - added by mario 4 years ago.

Download all attachments as: .zip

Change History (15)

Changed 4 years ago by mario

Changed 4 years ago by mario

Changed 4 years ago by mario

comment:1 Changed 4 years ago by mario

  • Description modified (diff)

comment:2 Changed 4 years ago by mario

  • Keywords salsita added
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 4 years ago by jand

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

comment:5 Changed 4 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Tester changed from Unknown to Scheer
  • The favicon remains, even on a new tab.

ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1

comment:6 Changed 4 years ago by mario

  • Milestone Adblock-Browser-for-iOS-next deleted
  • Resolution set to fixed
  • Status changed from reopened to closed

Removed the milestone and closed the issue. This change isn't supposed to land in 1.3.0.

comment:7 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-next

Rebased the current release branch to include this ticket.

comment:8 Changed 4 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • A new issue has now come of this change. When following step 6 and selecting the back option within the browser, the browser now crashes.

The HA crash report can be found here:(https://rink.hockeyapp.net/manage/apps/197999/app_versions/369/crash_reasons/113216632)

ABB 1.3.0-qa (844)
iPhonew 6 Plus - iOS 9.2.1

comment:9 Changed 4 years ago by jand

The issue should be fixed.

comment:10 Changed 4 years ago by jand

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:11 Changed 4 years ago by scheer

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • The above-described issue as per my comment above still occurs.

ABB 1.3.0-qa (844)
iPhone 6 Plus - iOS 9.2.1

comment:12 Changed 4 years ago by scheer

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Verified working set
  • No favicon is displayed for empty tabs in the tabs menu.

ABB 1.3.0-qa (851)
iPhone 6 Plus 9.2.1

Note: See TracTickets for help on using tickets.